Adapt distribution of profile scripts #283
Conversation
jjerphan
force-pushed
the
adapt-distribution-of-mamba.sh
branch
from
c1ed21b to
a771c6a
Compare
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12596639646. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12746273377. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12596662575. Examine the logs at this URL for more detail. |
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
adapt-distribution-of-mamba.sh
branch
from
a771c6a to
b81f865
Compare
jjerphan
requested review from
AntoinePrv,
JohanMabille,
SylvainCorlay,
adriendelsalle,
ericmjl and
wolfv
as code owners
There was a problem hiding this comment.
Hey @jjerphan, sorry that #282 was confusing. (What I put under "Installed packages" in that report were the commands that I used to achieve a broken environment with a mambaorg/micromamba container.)
By the way, I downloaded the 2.0.5 mamba packages from conda-forge for Windows and Linux. The Linux version doesn't seem to include any activation scripts (presumably they are currently provided transitively by libmamba). In contrast, the Windows version of mamba does include activation scripts in Scripts/ and condabin/ 🤔.
Another thought: would it be possible for someone on Linux to end up with build 2 of libmamba without the mamba.sh included in libmamba but with build 1 of mamba that also excludes mamba.sh? Answer: All good, this potential problem seems impossible because the pin on libmamba seems to include the build number.
| # ============ | ||
|
|
||
| -install(TARGETS ${mambaexe_targets}) | ||
| +# The script are only needed for mamba and not for micromamba |
There was a problem hiding this comment.
Note that I'm only claiming is that the mamba.sh/mamba.bat activation script should not be included with libmamba.
Probably your claim is correct, but it caught my eye. (It's been a long time since I've looked at the activation scripts for micromamba, and indeed the latest micromamba package doesn't seem to include any activation scripts.)
There was a problem hiding this comment.
For reference, this change was added based on this test in micromamba-feedstock independently from your remark.
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
changed the title
etc/profile.d/mamba.sh
jjerphan
force-pushed
the
adapt-distribution-of-mamba.sh
branch
3 times, most recently
from
8185b22 to
2045b78
Compare
|
Closing as superseded by #285. |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Fix #282 with patches of mamba-org/mamba#3723 and mamba-org/mamba#3739.